Skip to content

feat: move COS terraform modules from observability repo#36

Merged
sed-i merged 17 commits intomainfrom
feat/tf-migration
Jun 17, 2025
Merged

feat: move COS terraform modules from observability repo#36
sed-i merged 17 commits intomainfrom
feat/tf-migration

Conversation

@MichaelThamm
Copy link
Copy Markdown
Contributor

@MichaelThamm MichaelThamm commented Jun 13, 2025

Migrate the observability TF modules here. The long-term goal is to keep the product modules (COS, COS Lite, AWS-infra) here and move the coordinated charm modules to their mono repos once ready.

Tandem PR:

Future-looking issues created:

TODOs:

  • Create tandem removal PR for O11y and add migration notice
    • remove the TF files in the .gitignore
  • CTRL + F all instances of observability
  • fix justfile pass positive in CI
  • All docs should point at o11y-stack: ref
  • CTRL + F all instances of observability in docs
  • Deploy the main.tf
  • Remove ?ref=feat/tf-migration in repo

@sed-i
Copy link
Copy Markdown
Contributor

sed-i commented Jun 14, 2025

Nice!
Can you please also address as part of this PR:

@lucabello lucabello changed the title feat: COS TF modules feat: move COS terraform modules from observability repo Jun 16, 2025
@lucabello
Copy link
Copy Markdown
Contributor

The COS reproducer won't go active/idle because it doesn't include s3 storage. Arguably, that change is more involved than we need to.

I also imagine that if this CI ran on PRs, it would gate small reproducer-unrelated changes behind a very long test.

Personally, I would keep the CI changes to a separate PR.

@MichaelThamm MichaelThamm marked this pull request as draft June 16, 2025 12:10
@MichaelThamm
Copy link
Copy Markdown
Contributor Author

I think if we add a terraform validate step to our PR workflow, this would catch most regression bugs and general module integrity

@MichaelThamm MichaelThamm marked this pull request as ready for review June 16, 2025 15:47
Comment thread .github/workflows/_local-pull-request.yaml
Comment thread justfile
Comment thread terraform/modules/README.md
@MichaelThamm
Copy link
Copy Markdown
Contributor Author

MichaelThamm commented Jun 16, 2025

FYI issues are syncing to OPENG, I don't remember what we said about ownership for these issues. For example:

Will we just remember that they exist there and create new ones in O11y-stack?

Comment thread .github/workflows/_local-pull-request.yaml
Comment thread terraform/modules/README.md
Comment thread terraform/scripts/hcl-generator/generate_integrations.py Outdated
fix: update doc refs from o11y to o11y-stack
fix: split workflows for TF and GH yaml
@MichaelThamm
Copy link
Copy Markdown
Contributor Author

Merging on failing docs and TF CI because the migration caused mismatches. This will be resolved once the merge takes place. Tested with tfv and terraform fmt. The docs are pointing at the main branch which currently does not have the latest changes.

@sed-i sed-i merged commit 681c69d into main Jun 17, 2025
3 of 6 checks passed
@sed-i sed-i deleted the feat/tf-migration branch June 17, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants